[Replicant] [PATCH 1/1] smdk4412: remove all touchscreen binary firmware from the kernel

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Sun Mar 28 18:33:18 UTC 2021


On Fri, 26 Mar 2021 10:33:06 +0200
belgin <belginstirbu at hotmail.com> wrote:

> The removed files have unclear licensing statements
> and don't come with the corresponding source code.
> 
> So it's easier to just remove them than getting legal advice
> and trying to reconstruct their source code.
> 
> These files are #include'd in touchscreen drivers
> (even the .c files), but as it happens, it was not
> necessary to touch those drivers because Replicant
> doesn't use them (they are not checked in the defconfig
> of any of the supported devices).
> 
> That said, if anyone ever does use one of those drivers,
> it won't compile without changes.
> 
> So basically, none of the binary firmwares that are deleted
> by this patch ever ended up on a device running Replicant
> anyway.
> 
> Signed-off-by: belgin <belginstirbu at hotmail.com>
> ---
>  drivers/input/touchscreen/465_SMD_V66.h            | 2666 --------
>  drivers/input/touchscreen/477_SMD_V02.h            | 3986 -----------
>  drivers/input/touchscreen/477_SMD_V50.h            | 3989 -----------
>  drivers/input/touchscreen/G2M_12x09.c              | 3937 -----------
>  drivers/input/touchscreen/GC_BOOT.h                |  133 -
>  drivers/input/touchscreen/GFD_26x07.c              | 3937 -----------
>  drivers/input/touchscreen/GFS_03x14.c              | 3937 -----------
>  drivers/input/touchscreen/M0_D2_C1_VA8.h           | 2658 --------
>  drivers/input/touchscreen/M0_D2_C1_VAB.h           | 2658 --------
>  drivers/input/touchscreen/M0_D2_C1_VAC.h           | 3182 ---------
>  drivers/input/touchscreen/M0_D2_C1_VAD.h           | 3182 ---------
>  drivers/input/touchscreen/M0_D2_C1_VB1.h           | 3184 ---------
>  drivers/input/touchscreen/M0_D2_C1_VB2.h           | 3182 ---------
>  drivers/input/touchscreen/M0_D2_C1_VB4.h           | 3183 ---------
>  drivers/input/touchscreen/M0_D2_C1_VB5.h           | 2658 --------
>  drivers/input/touchscreen/MCH_SW889_R01_V01_bin.c  |  726 --
>  drivers/input/touchscreen/MCH_SW999_R03_V17_bin.c  |  726 --
>  drivers/input/touchscreen/MCH_SW999_R03_V18_bin.c  |  726 --
>  drivers/input/touchscreen/MMH_SM110S_R90_V30_bin.c |  825 ---
>  drivers/input/touchscreen/MMH_SM110S_R93_V38_bin.c |  786 ---
>  drivers/input/touchscreen/MMS100_ISC_Initial.h     |  133 -
>  .../input/touchscreen/MTH_SURFACE_TOUCH_0x58_bin.c | 1995 ------
>  .../input/touchscreen/PROXIMA_OCTA_465_VC56.hex    | 1714 -----
>  .../input/touchscreen/PROXIMA_OCTA_465_VC56_bin.c  | 1957 ------
>  .../input/touchscreen/Surface_touch_57_04_11_bin.c | 1995 ------
>  drivers/input/touchscreen/mxt1386_fw_ver10.h       | 3901 -----------
>  drivers/input/touchscreen/mxt224s_V1.1.AA_.h       | 6931
> -------------------- drivers/input/touchscreen/mxt224s_V1.1.C1_.h
>   | 3456 ---------- .../touchscreen/wacom/wacom_i2c_firm_P6_REV02.h
>  | 2071 ------ .../touchscreen/wacom/wacom_i2c_firm_P6_REV03.h    |
> 2071 ------ .../input/touchscreen/wacom/wacom_i2c_firm_g9.h    | 4867
> -------------- .../input/touchscreen/wacom/wacom_i2c_firm_p4.h    |
> 3075 --------- .../touchscreen/zinitix_touch_bt4x3_firmware.h     |
> 2056 ------ 33 files changed, 86483 deletions(-)
>  delete mode 100755 drivers/input/touchscreen/465_SMD_V66.h
>  delete mode 100644 drivers/input/touchscreen/477_SMD_V02.h
>  delete mode 100644 drivers/input/touchscreen/477_SMD_V50.h
>  delete mode 100644 drivers/input/touchscreen/G2M_12x09.c
>  delete mode 100644 drivers/input/touchscreen/GC_BOOT.h
>  delete mode 100644 drivers/input/touchscreen/GFD_26x07.c
>  delete mode 100644 drivers/input/touchscreen/GFS_03x14.c
>  delete mode 100644 drivers/input/touchscreen/M0_D2_C1_VA8.h
>  delete mode 100644 drivers/input/touchscreen/M0_D2_C1_VAB.h
>  delete mode 100644 drivers/input/touchscreen/M0_D2_C1_VAC.h
>  delete mode 100644 drivers/input/touchscreen/M0_D2_C1_VAD.h
>  delete mode 100644 drivers/input/touchscreen/M0_D2_C1_VB1.h
>  delete mode 100644 drivers/input/touchscreen/M0_D2_C1_VB2.h
>  delete mode 100644 drivers/input/touchscreen/M0_D2_C1_VB4.h
>  delete mode 100644 drivers/input/touchscreen/M0_D2_C1_VB5.h
>  delete mode 100755 drivers/input/touchscreen/MCH_SW889_R01_V01_bin.c
>  delete mode 100755 drivers/input/touchscreen/MCH_SW999_R03_V17_bin.c
>  delete mode 100644 drivers/input/touchscreen/MCH_SW999_R03_V18_bin.c
>  delete mode 100644 drivers/input/touchscreen/MMH_SM110S_R90_V30_bin.c
>  delete mode 100644 drivers/input/touchscreen/MMH_SM110S_R93_V38_bin.c
>  delete mode 100644 drivers/input/touchscreen/MMS100_ISC_Initial.h
>  delete mode 100644
> drivers/input/touchscreen/MTH_SURFACE_TOUCH_0x58_bin.c delete mode
> 100644 drivers/input/touchscreen/PROXIMA_OCTA_465_VC56.hex delete
> mode 100644 drivers/input/touchscreen/PROXIMA_OCTA_465_VC56_bin.c
> delete mode 100644
> drivers/input/touchscreen/Surface_touch_57_04_11_bin.c delete mode
> 100644 drivers/input/touchscreen/mxt1386_fw_ver10.h delete mode
> 100644 drivers/input/touchscreen/mxt224s_V1.1.AA_.h delete mode
> 100644 drivers/input/touchscreen/mxt224s_V1.1.C1_.h delete mode
> 100644 drivers/input/touchscreen/wacom/wacom_i2c_firm_P6_REV02.h
> delete mode 100644
> drivers/input/touchscreen/wacom/wacom_i2c_firm_P6_REV03.h delete mode
> 100755 drivers/input/touchscreen/wacom/wacom_i2c_firm_g9.h delete
> mode 100644 drivers/input/touchscreen/wacom/wacom_i2c_firm_p4.h
> delete mode 100644
> drivers/input/touchscreen/zinitix_touch_bt4x3_firmware.h

Acked-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>

I've also pushed this patch.

PS: I got some strange thing with git with this patch:
- I cannot apply your patch to my git tree but I can easily recreate it
  from the "delete mode". I used Parabola i686 and git 2.30.2 here.
- If I generate a patch out of the recreated patch (so with Parabola
  i686 and git 2.30.2), I cannot apply it to the repository with Debian
  stretch.

So something is fishy with the way git generates and/or applies patches
here.

When using meld to diff between your patch and the one I generated it
seems that your patch does the right thing (like the lines are long)
but my generated version insert some more line breaks somehow.

I've not pushed the investigation further yet though, but it might be
interesting to understand what is going on here, especially to
understand if we need to bugreport something to git.

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20210328/42092ea3/attachment.asc>


More information about the Replicant mailing list