[Replicant] [vendor_replicant-scripts] [PATCH 2/6] tests: lib: releases: remove unused install_zip function

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Mon Jan 10 14:59:46 UTC 2022


On Fri,  7 Jan 2022 19:56:04 +0100
Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org> wrote:

> The install_zip function being used is in replicant_releases.py.
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>
> ---
>  tests/src/lib/releases.py | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/tests/src/lib/releases.py b/tests/src/lib/releases.py
> index c75c1a4..054613f 100644
> --- a/tests/src/lib/releases.py
> +++ b/tests/src/lib/releases.py
> @@ -173,18 +173,6 @@ class RecoveryRuntime(object):
>  
>          self.host.run(['adb', 'reboot', 'recovery'])
>  
> -    @trace
> -    def install_zip(self, recovery_path):
> -        filename = recovery_path.split(os.sep)[-1]
> -        if not self.quiet:
> -            print('Installing {} on {}'.format(filename,
> self.device)) -
> -        if not self.quiet:
> -            print('Starting to install {} on {}'.format(filename,
> self.device)) -
> -        self.append_recovery_command('--sideload')
> -        self.host.run(['adb', 'reboot', 'recovery'])
> -
>  def install_release(local_config, major_version, minor_version,
> device): if not self.quiet:
>          print('Installing Replicant {} {} on {}'.format(filename,

I think that it's all the release.py file that is dead code: I've tried
without it with a GT-I9300 and it worked fine.

I'll fix that commit accordingly when pushing.

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20220110/cc305bae/attachment.asc>


More information about the Replicant mailing list