[Replicant] Patches to improve testing and code quality with libsamsung-ipc

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Mon Mar 28 20:20:14 UTC 2022


Hi,

This is the first patch serie since I got the modem working under
Parabola with (patches on top of) the Replicant 11 kenrel and
libsamsung-ipc.

This patch serie contains many improvement in the tool being used
for testing in this situation:
- A lot of the ipc-modem code was cleaned up, and minor bug(s)
  were fixed along the way.

- Journald support was added by adding syslog support. Before we were
  only collecting kernel logs and crash dumps. Now with it, we can
  also collect samsung-ipc and ipc-modem logs in journald. This way we
  can easily go back in time and compare with old logs, or collect
  everything for later analysis if there is a crash. So if for some
  reasons we hit a bug that is very hard to reproduce later on, we'd
  at least get as much information as we can from it, to
  potentially enable to fix it way faster.

- More strict compilation flags were introduced during the tests in
  order to find potential issues, and I also tried valgrind (with
  --leak-check=full) on the various tools and test-tools and I didn't
  find any memory leaks. I still need to integrate valgrind with the
  autotools at least though.

I've build-tested this patch set with the script/guix.scm, Replicant
4.2, and Replicant 6.0 since commit
979cffd3bfdbdf6e5316d6dbf400d7480a7121ed (tools: nv_data_imei: get rid
of missing initializer warning).

For the libsamsung-ipc patches, in addition to the patches that will
follow in a response to this mail, here's an URL to the see the
patches in a web interface:
https://git.replicant.us/contrib/GNUtoo/hardware_replicant_libsamsung-ipc/commit/?id=ce855d6cdbbabfacd574610d8374b134faeb7362

And here's how to get them in a git repository:
git clone https://git.replicant.us/GNUtoo/hardware_replicant_libsamsung-ipc
cd hardware_replicant_libsamsung-ipc
git show ce855d6cdbbabfacd574610d8374b134faeb7362

And for the vendor/replicant patches for Replicant 6.0, here's an URL
to the see the patches in a web interface:
https://git.replicant.us/contrib/GNUtoo/vendor_replicant/commit/?id=254625d43b2ddb38faddd9f5fa31c63ff4f3c956

And here's how to get them in a git repository:
git clone https://git.replicant.us/GNUtoo/vendor_replicant
cd vendor_replicant
git show 254625d43b2ddb38faddd9f5fa31c63ff4f3c956

Denis.



More information about the Replicant mailing list