[Replicant] [vendor_replicant-scripts] replicant_prepare_patch.py: V2 for "Build system and documentation fixes"

Joonas Kylmälä joonas.kylmala at iki.fi
Wed Aug 9 17:50:42 UTC 2023


Hi,

Denis 'GNUtoo' Carikli:
>> seems like somehow the prefix "replicant_prepare_patch.py:" is still
>> in the v2 patches (though, in the first one it should be). I wonder
>> how it gets added, does git send-email or similar command do it
>> somehow?
> I added it manually. Basically vendor_replicant-scripts has many
> different scripts, so I added it in the commit message.

Aha, there was a misunderstanding. See below.

> So as you rightly pointed out before I forgot to add
> 'replicant_prepare_patch.py' in the Subject of the cover email.

I was actually talking about the patches, not the cover email, having 
that prefix. The patches changed other files besides 
replicant_prepare_patch.py and so I assumed it must have been a mistake 
but now from your latest reply I understand it was intended and you 
wanted to communicate that the change relates to the 
replicant_prepare_patch.py script. In my head I was probably thinking 
the prefix should be "patches: <...>" or similar since it is under the 
patches directory but reading the Git history for 
vendor_replicant-scripts I see that the style you use is already the 
pre-existing style for that repository and makes sense, so it's all 
good. Just a misunderstanding on my behalf.

Joonas


More information about the Replicant mailing list