[Replicant] [PATCH] make video recording working again

[Simon Josefsson]

Wolfgang Wiedmeyer <wreg at wiedmeyer.de> writes:

> Hi,
>
> I reverted some changes and re-enabled hardware video
> encoding/decoding. Recording video now works fine with a Galaxy S3 and
> the proprietary firmware blobs (namely mfc_fw.bin, SlimISP_GD.bin and
> SlimISP_ZD.bin). Playback of the recorded videos with vlc is quite
> smooth, even in 1080p.
> Without the blobs, taking pictures still works fine (as before).
> BTW except for two bugs I noticed, the app Open Camera also works. This
> app provides lots of additional settings and is available from F-Droid. 

Nice!  Would this also fix ZXing?

Generally, I suspect there may be resistance to adopting this patch, but
to me it looks comparable to the already existing Wifi/Bluetooth
infrastructure support.  Replicant doesn't disable all Wifi/Bluetooth
support even though no hardware Replicant supports Wifi/Bluetooth
without non-free firmware.  The situation appears similar here.  If the
modules that you enable are all free software, I think they should be
built by default.  Are all of the following packages free software?

> +# MFC API
> +PRODUCT_PACKAGES += \
> +    libsecmfcdecapi \
> +    libsecmfcencapi
> +
> +# OMX
> +PRODUCT_PACKAGES += \
> +    libstagefrighthw \
> +    libSEC_OMX_Resourcemanager \
> +    libSEC_OMX_Core \
> +    libOMX.SEC.AVC.Decoder \
> +    libOMX.SEC.M4V.Decoder \
> +    libOMX.SEC.WMV.Decoder \
> +    libOMX.SEC.AVC.Encoder \
> +    libOMX.SEC.M4V.Encoder
> +#   libOMX.SEC.VP8.Decoder

The stagefright part had other concerns, but I guess that particular bug
has been resolved already.

> +++ b/configs/80cfw

I don't think this file should go into Replicant.  People who care about
non-free software has to install the files in the proper location
themselves.

> +busybox cp /system/vendor/firmware/SlimISP_*.bin /data/cfw/

Anyway, shouldn't you have a 'mkdir /data/cfw' first?

/Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20150924/47055670/attachment.asc>