[Replicant] [PATCH] make video recording working again

[Wolfgang Wiedmeyer]

Hi,

> Last time I checked, enabling hardware-accelerated video decoding (with
> the firmwares) required the non-free gralloc and EGL libraries and it
> also broke software-only decoding. Did the situation change?

The non-free gralloc and EGL libraries are not needed. But I must have
done something wrong when testing the patch at the time. It does in fact
brake software-only video decoding when the firmware binaries are not
installed.

> I have nothing against supporting hardware-accelerated video decoding
> when the firmwares are in place, but it must not impact users that don't
> install the proprietary firmwares negatively.

Would you accept the patch if I put the necessary code in some ifdefs?
Then if someone wants to use hardware encoding/decoding, something like
export USE_PROPRIETARY_HW_ENCODING_FW=true
has to be run before building the sources. The disadvantages would be
that building the rom from source is a requirement and there has to be a
hint somewhere on the wiki so that people are aware of this option.
Another way would be to detect at runtime if the firmware exists and
then automatically enable hw encoding, but I suspect that this is not an
easy task to implement and I don't know how to do this at the moment.

-- 
OpenPGP: 0F30 D1A0 2F73 F70A 6FEE  048E 5816 A24C 1075 7FC4
download: https://wiedmeyer.de/keys/ww.asc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20151211/d2d5ac8b/attachment.asc>