[Replicant] [PATCH v2][ 05/11] freedom-privacy-security-issues: Add an example of where the hardware knowledge is

[Paul Kocialkowski]

Le lundi 28 mars 2016 à 20:50 +0200, Denis 'GNUtoo' Carikli a écrit :
> Many people do think that the hardware knowledge is only in the kernel.
> This is to prevent confusion.
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
> ---
>  freedom-privacy-security-issues.php | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/freedom-privacy-security-issues.php b/freedom-privacy-security-
> issues.php
> index 775ed7f..2e4afe8 100644
> --- a/freedom-privacy-security-issues.php
> +++ b/freedom-privacy-security-issues.php
> @@ -32,6 +32,8 @@
>  				Hardware abstraction layers provide a generic
> interface for the framework to use.
>  				The framework itself provides an interface
> for applications that is independent of the device and the hardware.
>  				That way, applications can access hardware
> features through the generic framework interface, which will call the hardware
> abstraction layer libraries, ending up with the kernel communicating with the
> hardware.
> +				 For instance, when placing a call, the
> dialer application will communicate with the framework, which in turn will
> communicate with the hardware abstraction layer.
> +				 That hardware abstraction layer will
> implement the protocol to communicate with the modem. The Linux kernel will
> then forward the communication between the hardware abstraction layer and the
> modem CPU.

First, it looks like you're adding a heading whitespace after the tabulations,
please remove them.

I think we should really avoid using particular project names, such as Linux.
"The kernel" is clear enough and is what is used within the document. This is to
keep the document generic.

Also, "forward […] between […] and the modem CPU" sounds a bit odd, because the
modem CPU is a physical component and the HAL is software. I liked the idea of
saying that "The kernel will handle the transactions between the hardware
abstraction layer and the modem.", first because "forward" sounds one-way, when
it's really transactions and sounds more consistent.

So how about:

That hardware abstraction layer will implement the protocol to communicate with
the modem. The kernel will then handle the transactions between the hardware
abstraction layer and the modem.

Also, we should switch all "hardware abstraction layers" to "hardware
abstraction layer" (given that it's a single layer split across different
modules). Feel free to introduce that change in v3 or I'll do it later.

>  			</p>
>  			<p>
>  				Many other components of a mobile device also
> run software in different forms.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20160420/101bf385/attachment.asc>