[Replicant] replicant init.target.rc modifications

Simon Josefsson simon at josefsson.org
Sat Mar 4 19:36:53 UTC 2017


Hi all.

I noticed that the i9300 /init.target.rc of Replicant 6 deviates from
upstream wrt gps:

https://github.com/LineageOS/android_device_samsung_i9300/blob/cm-13.0/rootdir/init.target.rc#L105
https://git.replicant.us/replicant/device_samsung_i9300/blob/replicant-6.0/rootdir/init.target.rc#L96

The commit that introduced this difference said the reason was to reduce
'dmesg' spam:

https://git.replicant.us/replicant/device_samsung_i9300/commit/eb564f1803a0145eef68b59cdbb75362175d05a7

I have come up with another way to solve the 'dmesg' spam problem,
without having to deviate from upstream init.target.rc.  How about the
attached patch?  I have tested it on my phone, both with and without any
/system/bin/glgps binary, and there is no dmesg spam.

Thanks,
/Simon

From b421692b7da72424decc7ddc0db46956d182dc06 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <simon at josefsson.org>
Date: Sat, 4 Mar 2017 17:34:22 +0000
Subject: [PATCH] Reduce divergance from LineageOS init.target.rc -- resolve
 dmesg spam in another way.

---
 gps_daemon.sh          |  1 +
 rootdir/init.target.rc | 14 +++++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/gps_daemon.sh b/gps_daemon.sh
index 7cd6b64..6204974 100644
--- a/gps_daemon.sh
+++ b/gps_daemon.sh
@@ -1,2 +1,3 @@
 #shellscript as this is the only way selinux will allow this to proceed
 /system/bin/glgps -c /system/etc/gps.xml
+sleep 12345678
diff --git a/rootdir/init.target.rc b/rootdir/init.target.rc
index 4fcf34d..1652d6d 100644
--- a/rootdir/init.target.rc
+++ b/rootdir/init.target.rc
@@ -93,11 +93,11 @@ on fs
     # zram
     swapon_all /fstab.smdk4x12
 
-#on boot
+on boot
 # Start GPS daemon
-#service gps-daemon /system/bin/sh /system/bin/gps_daemon.sh
-#    class main
-#    socket gps seqpacket 0660 gps system
-#    user gps
-#    group system inet sdcard_rw gps
-#    seclabel u:r:glgps:s0
+service gps-daemon /system/bin/sh /system/bin/gps_daemon.sh
+    class main
+    socket gps seqpacket 0660 gps system
+    user gps
+    group system inet sdcard_rw gps
+    seclabel u:r:glgps:s0
-- 
2.11.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20170304/ee0d2cf0/attachment.asc>


More information about the Replicant mailing list