[Replicant] 'sign-build': Make certficate creation more robust

[doak]

Dear Denis,

thank you for your response!

>Since no one had the time to review it and that review has blocking its
>integration for a long time we could merge it anyway.

Please don't. At least one experienced developer for the toolchain should validate it. We really should keep this quality gate ;)

>Do you have an easy way to reproduce the issue you're fixing with your
>patch?

Good point, it could be that I have missed that. Just hold on till I provide the steps to reproduce.


Regards,
doak



On 4 May 2018 21:07:04 CEST, Denis 'GNUtoo' Carikli <GNUtoo at no-log.org> wrote:
>On Wed, 25 Apr 2018 02:18:18 +0200
>doak <doak+list at posteo.net> wrote:
>
>> Dear Replicant developers,
>Hi,
>
>> are there any news about my patches? I had neither got feedback nor
>> have they been integrated. 
>We need to get better at integrating people's patches.
>
>I wanted to test it but I've have a hard time finding the time to do it
>as the technical work I'm interested in doing for Replicant requires
>dedicating long continuous chunks of time.
>
>I think it could be improved by installing something like patchwork to
>keep track of patches.
>
>Do you have an easy way to reproduce the issue you're fixing with your
>patch? This way it could be tested faster.
>
>Also note that it only requires one other developer than you to 'Ack'
>the patch to be able to merge it.
>
>Since no one had the time to review it and that review has blocking its
>integration for a long time we could merge it anyway.
>
>Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 845 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20180505/34a3bb71/attachment.asc>