[Replicant] [PATCH] fix #1853 "Ecryption" typo in Settings App
kurtis
kurtis at riseup.net
Mon Sep 3 21:53:00 UTC 2018
Joonas Kylmälä:
> Denis 'GNUtoo' Carikli:
>> On Sun, 2 Sep 2018 21:17:21 +0200
>> Fil <fil.bergamo at riseup.net> wrote:
>>
>>> From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 2001
>>> From: Fil Bergamo <fil.bergamo at riseup.net>
>>> Date: Sun, 2 Sep 2018 16:44:44 +0000
>>> Subject: [PATCH] fix #1853 "Ecryption" typo in Settings App
>> Maybe mention the fact that the #1853 is a bug.
>> Something like that would be better:
>>> fix bug #1853 ("Ecryption" typo in Settings App)
>
> Actually if we intend to upstream the patches then there should not be
> any project specific bug numbers. On the other hand, if we know the
> patch is not going to go ever upstream we should use some searchable
> format, e.g. "Bug 1853: fix "Ecryption" typo".
Correct me if I'm wrong but this bug fix won't be upstreamed because the
bug was added accentually by Replicant devs a year ago:
https://git.replicant.us/replicant/packages_apps_settings/commit/?id=b9208e6feb5c472ea0a526332c9c9cf88f3b7f2f
I assume that we could upstream the added sentence once the spelling
error is fixed if we want to though.
> Joonas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20180903/2291f511/attachment-0001.asc>
More information about the Replicant
mailing list