[Replicant] Changes for 6.0 0004 release
Joonas Kylmälä
joonas.kylmala at iki.fi
Sun Sep 23 18:37:00 UTC 2018
Hi GNUtoo and others,
Denis 'GNUtoo' Carikli:
>> [0001-Revert-Point-ResXMLTree-to-a-copy-of-the-asset-buffe.patch
> The commit reverted by the patch above is this one:
>> commit 953d2a3493aaceb3209afc7eef1ff1e7f7242908
>> (replicant/replicant-6.0, m/replicant-6.0-dev) Author: Wolfgang
>> Wiedmeyer <wolfgit at wiedmeyer.de> Date: Thu Nov 2 23:01:34 2017 +0100
>>
>> Point ResXMLTree to a copy of the asset buffer in
>> AssetManager::getPkgName()
>> This ensures that there is no dangling pointer when the asset is
>> closed. Without this fix, a device ends up in a boot loop when an app
>> is installed that was created using aapt2.
>>
>> Reference:
>> https://github.com/TwidereProject/Twidere-Android/issues/963#issuecomment-335616312
>>
>> Signed-off-by: Wolfgang Wiedmeyer <wolfgit at wiedmeyer.de>
>
> Your commit message could give a bit more context on the issue, for
> instance with something like that:
>> This reverts commit 953d2a3493aaceb3209afc7eef1ff1e7f7242908.
>>
>> The 953d2a3493aaceb3209afc7eef1ff1e7f7242908 commit (Point ResXMLTree
>> to a copy of the asset buffer in AssetManager::getPkgName()) was
>> a fix for preventing devices from ending in a boot loop when an
>> application that was created with aapt2 was installed.
>>
>> Since upstream has now fixed it we can now drop this patch to use
>> upstream's fix instead.
please review the updated description for the revert commit.
side note: I pushed just now few of the merged branches to
git.replicant.us if you want to go look the end result.
Joonas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-Point-ResXMLTree-to-a-copy-of-the-asset-buffe.patch
Type: text/x-patch
Size: 1565 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20180923/95434f5d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20180923/95434f5d/attachment.asc>
More information about the Replicant
mailing list